-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow after instructions for resumable uploads in a single chunk #514
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #514 +/- ##
==========================================
+ Coverage 98.65% 98.66% +0.01%
==========================================
Files 50 50
Lines 7717 7785 +68
==========================================
+ Hits 7613 7681 +68
Misses 104 104
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
This seems to break the C++ tests: googleapis/google-cloud-cpp#12069 Specifically these two tests: Both use
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking for now until we figure out why the C++ tests are failing. It could be unrelated to these changes.
Noted, thanks for surfacing this! I've added a checklist above to track language tests are passing. |
We also see failed tests in Node.js with resumable upload request headers content-range set to storage-testbench/testbench/rest_server.py Lines 1007 to 1009 in a5a6592
|
Hi @ddelgrosso1 the node conformance tests now pass in my local dev environment. Could you help verify again when you have a chance, thanks! |
Hi @coryan I believe the two failed tests are related. I've updated the PR to only inspect after-bytes instructions and added a unit test. Could you help run the C++ test suite again when you have a chance, thanks! |
The C++ tests are now passing: googleapis/google-cloud-cpp#12069 |
Update - confirmed that no language test is adversely impacted by this PR. Merging and cutting a new release tag shortly |
Fixes #510
return-X-after-YK
andx-goog-emulator-instructions:return-503-after-256K
forced failures instructions for resumable uploads in both multiple chunks and a single chunk[ASK]
Given that languages have different implementations on restarting an interrupted upload, verify language (conformance) tests are not adversely impacted by these new changes
integration tests & conformance tests